Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pipes): update integration test, prune readme #31670

Closed
wants to merge 3 commits into from
Closed

chore(pipes): update integration test, prune readme #31670

wants to merge 3 commits into from

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 6, 2024

No description provided.

@github-actions github-actions bot added the p2 label Oct 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2024 00:23
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 6, 2024
@msambol
Copy link
Contributor Author

msambol commented Oct 6, 2024

@RaphaelManke jfyi. trying to keep your good work moving 😄

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol msambol changed the title chore(pipes): Update integration test, prune readme chore(pipes): update integration test, prune readme Oct 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 6, 2024 00:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a1da614
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@msambol
Copy link
Contributor Author

msambol commented Oct 6, 2024

I think the integration changes may not be possible because of circular dependencies? I'm going to close this for now and do the README updates in a different PR.

@msambol msambol closed this Oct 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msambol @aws-cdk-automation