fix(batch): changed Type to MANAGED for ManagedEc2EcsComputeEnvironment to avoid false drift in CloudFormation.

[ashishdhingra]

Issue # (if applicable)

Closes #31621.

Reason for this change

When defining the Type property for the AWS::Batch::ComputeEnvironment resource via the ManagedEc2EcsComputeEnvironment L2 construct or the CfnComputeEnvironment construct, if the value isn't set to MANAGED (case sensitive), this will result in a false positive drift result for this resource.

Description of changes

Changed Type to MANAGED for ManagedEc2EcsComputeEnvironment to avoid false drift in CloudFormation.

Per AWS::Batch::ComputeEnvironment, the Type property accepts MANAGED | UNMANAGED values. Although lowercase value (e.g. managed) works when using ManagedEc2EcsComputeEnvironment L2 construct, it results in false positive drift in CloudFormation console.

Description of how you validated changes

• Updated Unit tests
• Updated Integration tests snapshots

IMPORTANT NOTE (for reviewer): This simple case change from managed to MANAGED could cause resource update when deploying via cdk deploy. Please review if this should be mentioned as breaking change in PR. We are just correcting the casing for the value.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[ashishdhingra]

Exemption Request

This PR just changes the Type value to MANAGED (per docs). The existing integration test snapshots are updated. No new integration test is required.

[pahud]

try run

$ yarn integ test/aws-stepfunctions-tasks/test/batch/integ.run-batch-job.js --update-on-failed --disable-update-workflow
$ yarn integ test/aws-stepfunctions-tasks/test/batch/integ.submit-job.js --update-on-failed --disable-update-workflow

to update the snapshots

[comcalvi]

Can you check if this applies to unmanaged compute environments as well? If it does, we should fix it there too.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[ashishdhingra]

Can you check if this applies to unmanaged compute environments as well? If it does, we should fix it there too.

@comcalvi Thanks for the feedback. Added commit to correct casing for UnmamagedComputeEnvironment as well. Please review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 9ffc6bc
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[comcalvi]

On second thoughts, can you make this MANAGED and UNMANAGED thing an enum? That way we don't have to specify this with raw strings anymore. The enum should not be exposed to consumers of this construct.