feat(iot): scheduled audit #31776
feat(iot): scheduled audit #31776
Conversation
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
github-actions
bot
added
the
feature-request
aws-cdk-automation
added
the
pr/needs-community-review
| // Add a dependency because a `ScheduledAudit` needs to be created after the `AccountAuditConfiguration` is set up. | ||
| dailyAudit.node.addDependency(config); | ||
| weeklyAudit.node.addDependency(config); | ||
| monthlyAudit.node.addDependency(config); |
There was a problem hiding this comment.
Should we make config a required property of ScheduledAudit since it seems that we always need to set it as a dependency.
There was a problem hiding this comment.
That sounds great! I've updated my code.
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31779.
Reason for this change
Cloudformation supports for creating AWS IoT scheduled audit but AWS CDK does not.
Description of changes
ScheduledAuditconstructCloudformation does not support two audit checks. Therefore I have not implemented these checks in the
AuditCheckenum.If we try to deploy these checks, the deployment will fail.
Resource handler returned message: "Request contains an invalid Audit Check Name. (Service: Iot, Status Code: 400, Request ID: 3fb58c68-2845-4cc0-882c-7d9b5495ff2a)" (RequestToken: dcb09acd-609f-dfe5-7b63-6eb208052949, HandlerErrorCode: InvalidRequest)Description of how you validated changes
Added both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license