chore: upgrade eslint rule plugins

[rix0rrr]

In the new monorepo, we are required to use eslint@9 because projen forces it.

• eslint@9 in the new repo requires typescript-eslint@8, and rules have disappeared from those plugins and been moved to the @stylistic plugin.

We therefore move to @typescript-eslint@8 and @stylistic in this repo already, so that we can move the code over integrally.

• typescript-eslint@8 requires eslint@8, so also upgrade eslint to 8 in this repo.
• eslint@8 requires an update of eslint-plugin-jest

This change activated a number of rules that were being silently ignored in the past, or upgrades of rule packages work in more situations. In any case, it also includes a number of code fixes to make the new rules pass.

Notable changes:

• toThrowError -> toThrow
• toBeCalledWith -> toHaveBeenCalledWith
• Insertion of a bunch of missing semicolons

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (57bba19) to head (b511062).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32573   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files         108      108           
  Lines        7165     7165           
  Branches     1319     1319           
=======================================
  Hits         5651     5651           
  Misses       1330     1330           
  Partials      184      184           

Flag	Coverage Δ
suite.unit	78.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.86% <ø> (ø)

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b511062
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.