Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): remove unused v1 bootstrapping detection #32606

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 20, 2024

Reason for this change

Removing dead code in determineV1BootstrapSource which could not be called anymore since version always returns v2 these days.

Description of changes

Remove the dead code and conditional.
Also slightly changes the contract of CliToolkit.bootstrap() to take a BootstrapSource as part of options, instead of a the Bootstrapper.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

existing tests and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner December 20, 2024 12:53
@github-actions github-actions bot added the p2 label Dec 20, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2024 12:54
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 20, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 20, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (189bae3) to head (472059f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32606      +/-   ##
==========================================
+ Coverage   80.41%   80.49%   +0.07%     
==========================================
  Files         106      106              
  Lines        6955     6957       +2     
  Branches     1288     1289       +1     
==========================================
+ Hits         5593     5600       +7     
+ Misses       1183     1178       -5     
  Partials      179      179              
Flag Coverage Δ
suite.unit 80.49% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.49% <100.00%> (+0.07%) ⬆️

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Dec 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 20, 2024 16:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Dec 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 472059f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 20, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32606 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 4 of 6 required status checks are expected.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain merged commit 8b48fe8 into main Dec 20, 2024
14 of 17 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/remove-v1-bootstrap-detection branch December 20, 2024 18:57
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants