Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): supports minors 11.4.4, 10.11.10, 10.6.20, 10.5.27 for RDS for MariaDB #32632

Merged
merged 3 commits into from
Dec 23, 2024
Merged

feat(rds): supports minors 11.4.4, 10.11.10, 10.6.20, 10.5.27 for RDS for MariaDB #32632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d98949
chore(rds): supports minors 11.4.4, 10.11.10, 10.6.20, 10.5.27 for RD…
mazyu36 Dec 22, 2024
4698d70
update unit tests
mazyu36 Dec 22, 2024
aec7c3e
Merge branch 'main' into maria-db-minor
mergify[bot] Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,8 @@ export class MariaDbEngineVersion {
public static readonly VER_10_5_25 = MariaDbEngineVersion.of('10.5.25', '10.5');
/** Version "10.5.26". */
public static readonly VER_10_5_26 = MariaDbEngineVersion.of('10.5.26', '10.5');
/** Version "10.5.27". */
public static readonly VER_10_5_27 = MariaDbEngineVersion.of('10.5.27', '10.5');

/** Version "10.6" (only a major version, without a specific minor version). */
public static readonly VER_10_6 = MariaDbEngineVersion.of('10.6', '10.6');
Expand Down Expand Up @@ -543,6 +545,8 @@ export class MariaDbEngineVersion {
public static readonly VER_10_6_18 = MariaDbEngineVersion.of('10.6.18', '10.6');
/** Version "10.6.19". */
public static readonly VER_10_6_19 = MariaDbEngineVersion.of('10.6.19', '10.6');
/** Version "10.6.20". */
public static readonly VER_10_6_20 = MariaDbEngineVersion.of('10.6.20', '10.6');

/** Version "10.11" (only a major version, without a specific minor version). */
public static readonly VER_10_11 = MariaDbEngineVersion.of('10.11', '10.11');
Expand All @@ -558,8 +562,12 @@ export class MariaDbEngineVersion {
public static readonly VER_10_11_8 = MariaDbEngineVersion.of('10.11.8', '10.11');
/** Version "10.11.9". */
public static readonly VER_10_11_9 = MariaDbEngineVersion.of('10.11.9', '10.11');
/** Version "10.11.10". */
public static readonly VER_10_11_10 = MariaDbEngineVersion.of('10.11.10', '10.11');
/** Version "11.4.3". */
public static readonly VER_11_4_3 = MariaDbEngineVersion.of('11.4.3', '11.4');
/** Version "11.4.4". */
public static readonly VER_11_4_4 = MariaDbEngineVersion.of('11.4.4', '11.4');

/**
* Create a new MariaDbEngineVersion with an arbitrary version.
Expand Down
4 changes: 4 additions & 0 deletions packages/aws-cdk-lib/aws-rds/test/instance-engine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ describe('instance engine', () => {
['10.5.24', rds.MariaDbEngineVersion.VER_10_5_24],
['10.5.25', rds.MariaDbEngineVersion.VER_10_5_25],
['10.5.26', rds.MariaDbEngineVersion.VER_10_5_26],
['10.5.27', rds.MariaDbEngineVersion.VER_10_5_27],
['10.6', rds.MariaDbEngineVersion.VER_10_6],
['10.6.13', rds.MariaDbEngineVersion.VER_10_6_13],
['10.6.14', rds.MariaDbEngineVersion.VER_10_6_14],
Expand All @@ -289,14 +290,17 @@ describe('instance engine', () => {
['10.6.17', rds.MariaDbEngineVersion.VER_10_6_17],
['10.6.18', rds.MariaDbEngineVersion.VER_10_6_18],
['10.6.19', rds.MariaDbEngineVersion.VER_10_6_19],
['10.6.20', rds.MariaDbEngineVersion.VER_10_6_20],
['10.11', rds.MariaDbEngineVersion.VER_10_11],
['10.11.4', rds.MariaDbEngineVersion.VER_10_11_4],
['10.11.5', rds.MariaDbEngineVersion.VER_10_11_5],
['10.11.6', rds.MariaDbEngineVersion.VER_10_11_6],
['10.11.7', rds.MariaDbEngineVersion.VER_10_11_7],
['10.11.8', rds.MariaDbEngineVersion.VER_10_11_8],
['10.11.9', rds.MariaDbEngineVersion.VER_10_11_9],
['10.11.10', rds.MariaDbEngineVersion.VER_10_11_10],
['11.4.3', rds.MariaDbEngineVersion.VER_11_4_3],
['11.4.4', rds.MariaDbEngineVersion.VER_11_4_4],
])('is passed correctly for %s', (engineVersion, version) => {

// WHEN
Expand Down
Loading