-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw ValidationError
instead of untyped errors in L1s
#33032
base: main
Are you sure you want to change the base?
Conversation
ValidationError
in L1sValidationError
instead of untyped errors in L1s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but i assume you'll want to wait until s3/validation-error is merged?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33032 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 224 224
Lines 13755 13755
Branches 2413 2413
=======================================
Hits 11209 11209
Misses 2273 2273
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This will need more changes. Dismissing review to force a re-review later.
Drafting the PR. This clearly needs more work. |
Issue
All L1s for #32569
Description of changes
Updated the codegen to throw the correct error.
Instead of
we now throw
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests. Exemptions granted as this is basically a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license