Fix open tunnel bug when NO_PROXY is unset #8039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
reviewed
Jul 18, 2023
hsingh6764
force-pushed
the
fix-open-tunnel-bug
branch
from
79212e8
to
3e912a5
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #8039 +/- ##
==========================================
- Coverage 93.12% 93.11% -0.02%
==========================================
Files 363 363
Lines 38288 38288
Branches 6126 6126
==========================================
- Hits 35656 35652 -4
- Misses 1962 1966 +4
Partials 670 670
|
kyleknap
force-pushed
the
fix-open-tunnel-bug
branch
from
3e912a5
to
13c9e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8023
Description of changes:
Allow NO_PROXY to be
None. If it is not defined or is empty orNonethen we don't check.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.