[v2] Turn on checksum validation for CRT S3 client #8298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2-s3-crt #8298 +/- ##
=============================================
- Coverage 93.19% 93.18% -0.01%
=============================================
Files 364 364
Lines 38506 38519 +13
Branches 6169 6171 +2
=============================================
+ Hits 35884 35893 +9
- Misses 1950 1954 +4
Partials 672 672 ☔ View full report in Codecov by Sentry. |
For uploads, the CRT S3 client will add CRC32 trailing checksums. For downloads, the CRT S3 client will validate checksums associated to the object when possible.
kyleknap
force-pushed
the
v2-crt-checksums
branch
from
daea3a0
to
3a7e6e4
Compare
graebm
reviewed
Nov 13, 2023
| @@ -206,6 +206,7 @@ def upload(self, fileobj, bucket, key, extra_args=None, subscribers=None): | |||
| extra_args = {} | |||
| if subscribers is None: | |||
| subscribers = {} | |||
| self._validate_checksum_algorithm_supported(extra_args) | |||
There was a problem hiding this comment.
somewhat offtopic: Noticing that CRTTransferManager doesn't validate input as extensively as the classic TransferManager:
aws-cli/awscli/s3transfer/manager.py
Lines 318 to 319 in d61d077
There was a problem hiding this comment.
Yeah I think we should follow up on validating extra args in another PR.
graebm
approved these changes
Nov 13, 2023
nateprewitt
reviewed
Nov 13, 2023
This is was made to keep parity with the pure Python transfer manager which accepts lowercase algorithm values.
nateprewitt
approved these changes
Nov 13, 2023
kyleknap
added a commit
that referenced
this pull request
Nov 13, 2023
[v2] Turn on checksum validation for CRT S3 client
kyleknap
added a commit
to kyleknap/aws-cli
that referenced
this pull request
Nov 22, 2023
[v2] Turn on checksum validation for CRT S3 client
kyleknap
added a commit
that referenced
this pull request
Nov 22, 2023
[v2] Turn on checksum validation for CRT S3 client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For uploads, the CRT S3 client will add CRC32 trailing checksums. For downloads, the CRT S3 client will validate checksums associated to the object when possible. This is also inline with the proposed changes in this s3transfer PR: boto/s3transfer#277. The plan is backport this to s3transfer once merged.