Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Use higher key size for TestSha256RSADigestValidator #8838

Closed
wants to merge 1 commit into from

Conversation

fossdd
Copy link

@fossdd fossdd commented Aug 2, 2024

Issue #, if available:

Description of changes:

cryptography 43.0.0 requires bumped the minimum key size to 1024.

Since rsa.generate_private_key() is only used in this test, this is fine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cryptography 43.0.0 requires bumped the minimum key size to 1024
@kdaily
Copy link
Member

kdaily commented Sep 11, 2024

Hi @fossdd! Thanks for opening this. I came across this separately and bumped up the keysize to 2048 (#8903). Closing this out for now. We are still working towards moving the pin for cryptography.

@kdaily kdaily closed this Sep 11, 2024
@fossdd
Copy link
Author

fossdd commented Sep 11, 2024

I came across this separately and bumped up the keysize to 2048.

That's great! Thanks!

We are still working towards moving the pin for cryptography.

Yeah, downstream at Alpine (and other distros) we mostly use latest version of libraries and notice changes like that early. But I don't mind fixing them and upstream them, if that makes life easier (and hopefully doesn't duplicate work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants