-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Enable support for loading files into nested parameters #9012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only had time to review the implementation for parsing the @=
operator. I should be able to take a look at the implementation for quoted keys, tests, and the questions you had later this week.
Moving forward, we should try to cut separate PRs targeting a feature branch when implementing multiple features. IMO, support for shorthand paramfiles and quoted keys are related, but distinct features.
85eba4d
to
88e1f9c
Compare
bec8cf7
to
ddacb06
Compare
@@ -15,8 +15,7 @@ | |||
import copy | |||
|
|||
from awscli.compat import compat_open | |||
from awscli.argprocess import ParamError | |||
|
|||
from awscli import argprocess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewer, this change was made to avoid a circular import error.
b6339ce
to
9d0e256
Compare
9d0e256
to
53aa7d5
Compare
Related Issues:
Description of changes:
file://
orfileb://
prefix.Description of tests:
Usage Example:
For example, suppose there is a file named
tagval.txt
located atpath/to/tagval.txt
on the host machine with contentsTagValue
.aws codecommit tag-resource --resource-arn <RESOURCE_ARN> --tags TagKey@=file://path/to/tagval.txt
The above command will parse the tags parameter as
"tags": {"TagKey": "TagValue"}}
. Notice the need for the assignment operator@=
. This operator is required to prevent breaking existing customers that may be using a nested parameter value that happens to start withfile://
already.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.