-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uses dependencies for sphinx check #9050
Conversation
Update actions/checkout to v4 and actions/setup-python to v5.
That's not the right underlying issue, though we should update these. We pin the Sphinx version in the requirements file: Line 1 in 5b66447
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not have dependabot managing these? We should move to hashes ideally and let that all be automated.
Agree, looking at enabling that for this branch. Testing locally first to see that Sphinx build is going to work OK with new versions. |
To make it easier to install the latest, relax the versions in requirements.txt and use pip-compile from pip-tools to make a lockfile. Update the `make install` command to use the new lockfile.
2466b2f
to
88945bb
Compare
Added dependabot management of GH actions and dependencies on the |
This was previously ignoring a non-existent directory. Adds the static files directory (which currently has some long lines that should remain). Also, specifically enable all linting checks except for leaked markup, which checks for things like raw backticks. These are used in bonafide examples, so they should be ignored.
eedc7bd
to
2953926
Compare
Update
actions/checkout
to v4 andactions/setup-python
to v5 when building the GitHub pages-based contributing guide.Builds are failing with the following:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.