Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS CRT instead of cryptography for EC2 decrypt password #9051

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

kdaily
Copy link
Member

@kdaily kdaily commented Nov 1, 2024

Issue #, if available:

NA

Description of changes:

Replace use of cryptography methods with AWS CRT to perform password decryption when calling the aws ec2 get-password-data command with a supplied private key file.

Testing:

  • Existing test suites cover decryption methods, and they pass.
  • Manually compared results of retrieving password from the AWS Console for a Windows EC2 instance to the result using the new implementation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily changed the title Use AWS CRT instead of cryptography Use AWS CRT instead of cryptography for EC2 decrypt password Nov 1, 2024
@kdaily kdaily force-pushed the ec2-decryptpassword-to-crt branch 2 times, most recently from 83c2789 to 7df1ef7 Compare November 6, 2024 18:34
@kdaily kdaily marked this pull request as ready for review November 6, 2024 18:34
@kdaily kdaily requested review from a team, ashovlin, aemous and hssyoo November 6, 2024 18:34
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@kdaily kdaily merged commit e803683 into aws:cryptography-to-crt Nov 7, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants