Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix non-deterministic S3 test failure. #9068

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Nov 11, 2024

Description of changes:

  • Replace a hard-coded part number with mock.ANY to prevent non-deterministic test failures.

Description of tests:

  • Ran the updates test locally and observed it passes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily
Copy link
Member

kdaily commented Nov 11, 2024

LGTM once tests pass. Could you update the GitHub description to link to the AWS CLI v1 version of this (#9069)? Should there be an issue with it, that will help quickly tracking the changes made. Thanks!

@aemous aemous merged commit 8eb66de into aws:v2 Nov 11, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants