Add MRAP support for CRT s3transfer integration #9078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
reviewed
Nov 15, 2024
| @@ -156,6 +160,26 @@ def _assert_exected_s3express_request( | |||
| awscrt.auth.AwsSigningAlgorithm.V4_S3EXPRESS | |||
| ) | |||
|
|
|||
| def _assert_exected_mrap_request( | |||
There was a problem hiding this comment.
nit:
Suggested change
| def _assert_exected_mrap_request( | |
| def _assert_expected_mrap_request( |
This is a copy paste from other mis-named tests, so fine to clean this up at another time.
There was a problem hiding this comment.
I'll do a quick follow up PR cleaning up everything so we don't lose it if one of these needs to get reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (previously #9076) patches a gap with SigV4a signing for the CRT S3 transfer manager. On performance-optimized instance types [list], the CRT will auto-enable itself for all high-level
aws s3commands. This may lead to signature mismatches for Multi-Region Access Points backed by buckets in other regions.Customers currently encountering this issue can bypass the problem by setting
preferred_transfer_clienttoclassic(docs). That mitigation will no longer be needed after this patch is merged.