[v2] Modifies botocore tests to use the defaults created in configprovider.py #9209
+39
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
get_botocore_default_config_mapping
to our test utilities so botocore-specific test imports are preserved.test_max_attempts_expected_if_retries_is_none
intests/unit/botocore/test_args.py
to reflect the fact that CLI v2 uses a defaultmax_attempts
value of 3, which is not the case for botocore.test_max_attempts_expected_if_retries_is_none
, and I changed the expected assertion to be thatmax_attempts
is the expected default CLI v2 value (3).Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.