Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Modifies botocore tests to use the defaults created in configprovider.py #9211

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Jan 14, 2025

Issue #, if available:

Description of changes:

  • Ports Modifies the tests to use the defaults created in configprovider.py boto/botocore#3334 into our vendored botocore
  • Import get_botocore_default_config_mapping to our test utilities so botocore-specific test imports are preserved.
  • Modify the test test_max_attempts_expected_if_retries_is_none in tests/unit/botocore/test_args.py to reflect the fact that CLI v2 uses a default max_attempts value of 3, which is not the case for botocore.
    • In particular, I changed the name of the test to test_max_attempts_expected_if_retries_is_none, and I changed the expected assertion to be that max_attempts is the expected value resolved by config provider

Description of tests:

  • Ran and passed all botocore unit tests
  • Manually set AWS_MAX_ATTEMPTS to a different value (8) and ensured that test_max_attempts_expected_if_retries_is_none still passes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team January 14, 2025 20:56
@aemous aemous merged commit 7af769a into aws:v2 Jan 14, 2025
41 of 45 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cb6373) to head (cf80d6f).
Report is 62 commits behind head on v2.

Additional details and impacted files
@@    Coverage Diff     @@
##   v2   #9211   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants