docs(power): update createClassSerdes and createClassSerdesWithDates example to use no-arg constructor#171
Open
docs(power): update createClassSerdes and createClassSerdesWithDates example to use no-arg constructor#171
Conversation
fix: update createClassSerdesWithDates example to use no-arg constructor
fix: update createClassSerdesWithDates example to use no-arg constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The createClassSerdes and createClassSerdesWithDates function requires a no-argument constructor (new () => T) as defined in the SDK type signature:
The JSDoc also explicitly states: "The class constructor (must have no required parameters)"
The current example uses a constructor with 3 required parameters, which causes a TypeScript compile error:
Description of changes:
Updated createClassSerdesWithDates and createClassSerdesWithDates example to use no-arg constructor.