Skip to content

[Bugfix] adding completableFuture docs and minor bug fixes#111

Merged
zhongkechen merged 2 commits intomainfrom
phaser
Feb 24, 2026
Merged

[Bugfix] adding completableFuture docs and minor bug fixes#111
zhongkechen merged 2 commits intomainfrom
phaser

Conversation

@zhongkechen
Copy link
Copy Markdown
Contributor

@zhongkechen zhongkechen commented Feb 19, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

Fix #97

Follow-up actions on previous PR #103

Description

  • Added more comments to CompletableFuture related code
  • Added a new design doc ADR-003 for CompletableFuture based operation coordination
  • Removed duplicate method isTerminalStatus
  • Fixed a bug in ChildContextOperation that doesn't handle SuspendExecutionException properly, causing flaky test cases
  • Fixed minor issues with runners
    • Added handling of errors in CloudDurableTestRunner
    • Fixed LocalDurableTestRunner gets stuck when skipTimer is true
  • Replaced some magic values in test cases with constants
  • simplified thread local and active thread management
    • removed unset/reset thread local object from waitForOperationCompletion. Thread local object is set when the thread is started and it is recycled when the thread is terminated.
    • removed thread type from active thread tracker. Only thread id is needed to track active threads.
    • renamed some methods to better reflect the purpose and avoid confusion. Context is renamed to ThreadContext to reflect that it's stored in thread local.

Demo/Screenshots

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes? Yes

Integration Tests

Have integration tests been written for these changes? Yes

Examples

Has a new example been added for the change? (if applicable) Yes

@zhongkechen zhongkechen marked this pull request as ready for review February 19, 2026 23:11
@zhongkechen zhongkechen self-assigned this Feb 20, 2026
@zhongkechen zhongkechen changed the title [Improvement] enable nested async steps [Improvement] adding completableFuture docs and removing nested step restriction Feb 20, 2026
@zhongkechen zhongkechen changed the title [Improvement] adding completableFuture docs and removing nested step restriction [Improvement] adding completableFuture docs Feb 20, 2026
@zhongkechen zhongkechen changed the title [Improvement] adding completableFuture docs [Improvement] adding completableFuture docs and minor code improvements Feb 20, 2026
@zhongkechen zhongkechen changed the title [Improvement] adding completableFuture docs and minor code improvements [Bugfix] adding completableFuture docs and minor bug fixes Feb 20, 2026
fix local runner with skipTime

fix handling of SuspendExecutionException in ChildContextOperation
@zhongkechen zhongkechen requested a review from SilanHe February 24, 2026 17:48
@zhongkechen zhongkechen merged commit e4d19d2 into main Feb 24, 2026
10 checks passed
@zhongkechen zhongkechen deleted the phaser branch February 24, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor]: issues with Phaser

2 participants