Conversation
zhongkechen
reviewed
Mar 12, 2026
| handleCheckFailure(e); | ||
| } finally { | ||
| try { | ||
| deregisterActiveThread(threadId); |
Contributor
There was a problem hiding this comment.
Did Kiro read from the old version of code? deregister now called in StepContext.
|
|
||
| CompletableFuture.runAsync( | ||
| () -> { | ||
| setCurrentThreadContext(new ThreadContext(threadId, ThreadType.STEP)); |
Contributor
There was a problem hiding this comment.
This now happens inside StepContext
zhongkechen
reviewed
Mar 12, 2026
sdk/src/main/java/software/amazon/lambda/durable/operation/WaitForConditionOperation.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#90
Description
Initial commit of new waitForCondition operation (not including tests).
WORK IN PROGRESS
Demo/Screenshots
WIP
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? WIP
Integration Tests
Have integration tests been written for these changes? WIP
Examples
Has a new example been added for the change? (if applicable) WIP