update the design doc with the threading details#211
Open
zhongkechen wants to merge 2 commits intomainfrom
Open
update the design doc with the threading details#211zhongkechen wants to merge 2 commits intomainfrom
zhongkechen wants to merge 2 commits intomainfrom
Conversation
ayushiahjolia
previously approved these changes
Mar 13, 2026
dhegberg
reviewed
Mar 13, 2026
| #### 2. Suspension Detection - Unified Thread Counting | ||
| We use thread counting as the suspension trigger because threads naturally deregister when they cannot make progress on durable operations. This provides a simple, unified mechanism that works across all operation types. | ||
| `runUntilCompleteOrSuspend` uses `CompletableFuture.anyOf(userFuture, executionExceptionFuture)`: | ||
| - If `handlerFuture` completes first → `SUCCESS` (or `FAILED` if the handler threw). |
Contributor
There was a problem hiding this comment.
Should this be userFuture?
Contributor
Author
There was a problem hiding this comment.
handlerFuture is correct. Updated the above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#184
Description
Updated the threading section in design doc
Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Integration Tests
Have integration tests been written for these changes?
Examples
Has a new example been added for the change? (if applicable)