Skip to content

[refactor]: minor improvements#240

Merged
zhongkechen merged 1 commit intomainfrom
minors
Mar 19, 2026
Merged

[refactor]: minor improvements#240
zhongkechen merged 1 commit intomainfrom
minors

Conversation

@zhongkechen
Copy link
Contributor

@zhongkechen zhongkechen commented Mar 19, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

Description

Very minor improvements

  • amended javadoc comments
  • fixed obsolete design docs
  • unified the parameter name for result type
  • added unit tests for DurableConfig::validateConfiguration
  • fixed a todo in wait operation (calculate polling interval based on scheduledEndTimestamp)

Demo/Screenshots

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes? added

Integration Tests

Have integration tests been written for these changes? N/A

Examples

Has a new example been added for the change? (if applicable) N/A

@zhongkechen zhongkechen marked this pull request as ready for review March 19, 2026 22:32
@zhongkechen zhongkechen requested a review from a team March 19, 2026 22:32
@zhongkechen zhongkechen self-assigned this Mar 19, 2026
// Lambda response size limit is 6MB minus small epsilon for envelope
private static final int LAMBDA_RESPONSE_SIZE_LIMIT = 6 * 1024 * 1024 - 50;

private DurableExecutor() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Do we need this constructor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongkechen zhongkechen merged commit 67fedbc into main Mar 19, 2026
12 checks passed
@zhongkechen zhongkechen deleted the minors branch March 19, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants