Merged
Conversation
zhongkechen
commented
Mar 31, 2026
|
|
||
| // Poll for READY status and then execute the step again | ||
| pollReadyAndExecuteStepLogic(getOperation(), attempt + 1); | ||
| pollReadyAndExecuteStepLogic(Instant.now().plusSeconds(retryDelayInSeconds), attempt + 1); |
Contributor
Author
There was a problem hiding this comment.
For Retry OperationAction, the backend doesn't immediately return an operation with the nextAttemptTimestamp, which is while we get null pointer for it here.
Contributor
There was a problem hiding this comment.
Do we have any tests that needs to be updated?
Contributor
Author
There was a problem hiding this comment.
Existing tests are able to cover this with the change in handling user function exceptions.
ayushiahjolia
approved these changes
Mar 31, 2026
wangyb-A
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fixes #295
Description
The step operation throws a
NullPointerExceptionwhen it fails and polls for the next attempt.The exception is thrown because the
nextAttemptTimestampparameter is null setting up the polling.The exception was swallowed, leaving the polling unset.
Fix:
Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Integration Tests
Have integration tests been written for these changes?
Examples
Has a new example been added for the change? (if applicable)