Merged
Conversation
yaythomas
requested changes
Oct 29, 2025
ghost
force-pushed
the
quinsclr/fix-concurrency-on-map-and-parallel
branch
2 times, most recently
from
e3235e7 to
00ab201
Compare
Parallel and Map now replays without using threading. Changes: - context.map and context.parallel now call child_handler directly and create their own operation identifier - `map_handler` and `parallel_handler` now checks the state of the operation and when we've already succeeded, we use `executor.replay` We test this by mocking the state, and ensuring we first run through execute and then through replay and get back the correct results.
ghost
force-pushed
the
quinsclr/fix-concurrency-on-map-and-parallel
branch
from
00ab201 to
f6f3d46
Compare
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
yaythomas
approved these changes
Oct 29, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel and Map now replays without using threading.
Changes:
create their own operation identifier
operation and when we have already succeeded, we use executor.replay
We test this by mocking the state, and ensuring we first run through
execute and then through replay and get back the correct results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes: #92