Merged
Conversation
ghost
force-pushed
the
serialize-batch-result
branch
from
d30b11b to
4b87d75
Compare
Contributor
|
superseded by #115 |
ghost
reopened this
ghost
force-pushed
the
serialize-batch-result
branch
from
4b87d75 to
13998d2
Compare
- Adds serialization for batch result in the serdes module. Unfortunately we need to do an adhoc import as we are dealing with cyclical dependencies.
ghost
force-pushed
the
serialize-batch-result
branch
from
13998d2 to
bbed24a
Compare
Changes: - add tests to verify BatchResult is serialized - add tests to verify BatchResult actually serializes by default - add tests to verify we pass custom serdes and that is used to serialize BatchResult
ghost
commented
Nov 6, 2025
Comment on lines
+973
to
+981
| with patch.object( | ||
| DurableContext, "_create_step_id_for_logical_step", create_id | ||
| ): | ||
| context = DurableContext(state=mock_state) | ||
| result = context.map(["a", "b"], lambda ctx, item, idx, items: item) | ||
|
|
||
| assert len(mock_serdes_serialize.call_args_list) == 3 | ||
| parent_call = mock_serdes_serialize.call_args_list[2] | ||
| assert parent_call[1]["value"] is result |
Author
There was a problem hiding this comment.
Verify that we have called serialize with the same BatchResult that we are actually returning.
Comment on lines
+1035
to
+1041
| assert isinstance(result, BatchResult) | ||
| assert len(mock_serialize.call_args_list) == 3 | ||
| parent_call = mock_serialize.call_args_list[2] | ||
| assert parent_call[1]["serdes"] is None | ||
| assert isinstance(parent_call[1]["value"], BatchResult) | ||
| assert parent_call[1]["value"] is result | ||
|
|
Author
There was a problem hiding this comment.
Verify that we have called with the same BatchResult we return, and default serializer actually serializes.
Comment on lines
+991
to
+994
| with patch( | ||
| "aws_durable_execution_sdk_python.serdes.serialize", wraps=serialize | ||
| ) as mock_serialize: | ||
| importlib.reload(child_module) |
Author
There was a problem hiding this comment.
We wrap to ensure we are actually calling serialize
Comment on lines
+1099
to
+1104
| assert isinstance(result, BatchResult) | ||
| assert len(mock_serialize.call_args_list) == 3 | ||
| parent_call = mock_serialize.call_args_list[2] | ||
| assert parent_call[1]["serdes"] is custom_serdes | ||
| assert isinstance(parent_call[1]["value"], BatchResult) | ||
| assert parent_call[1]["value"] is result |
Author
There was a problem hiding this comment.
Ensure custom serdes is actually called with same returned batch result, and we call serialize.
ghost
marked this pull request as ready for review
wangyb-A
reviewed
Nov 6, 2025
Contributor
wangyb-A
left a comment
wangyb-A
left a comment
There was a problem hiding this comment.
LGTM!
concurrency/__init __ .py exists cuz Ruff was complaining :D
yaythomas
reviewed
Nov 6, 2025
| case list() | tuple() | dict(): | ||
| return self.container_codec.encode(obj) | ||
| case _: | ||
| if isinstance(obj, BatchResult): |
Contributor
There was a problem hiding this comment.
why here too? (see line 248)
Author
There was a problem hiding this comment.
Oooopsies, remnant from cyclical dependency
yaythomas
requested changes
Nov 6, 2025
yaythomas
approved these changes
Nov 7, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.