Skip to content

Fix: stop on min successful breach#127

Merged
2 commits merged intois-completefrom
stop-on-min-successful-breach
Nov 7, 2025
Merged

Fix: stop on min successful breach#127
2 commits merged intois-completefrom
stop-on-min-successful-breach

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 7, 2025

  • Add test that verifies branch threads still execute even after reaching min successful
  • fix(sdk): Fix branch cancellation logic to break upon reaching min_successful

Changes:

  • Fixes a bug where we Futures are not cancelled if we reach early termination, and thus all branches in map and parallel were running until the end.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ghost ghost requested review from wangyb-A and yaythomas as code owners November 7, 2025 06:34
@ghost ghost force-pushed the is-complete branch from 4bd1206 to abc4230 Compare November 7, 2025 06:44
@ghost ghost force-pushed the stop-on-min-successful-breach branch from 300096f to c0b6f2d Compare November 7, 2025 06:47
@ghost ghost merged commit 8004422 into is-complete Nov 7, 2025
2 checks passed
@ghost ghost deleted the stop-on-min-successful-breach branch November 7, 2025 11:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants