Skip to content

fix: concurrent execuion completion logic#128

Closed
vip-amzn wants to merge 1 commit intomainfrom
fix_concurrent_exec
Closed

fix: concurrent execuion completion logic#128
vip-amzn wants to merge 1 commit intomainfrom
fix_concurrent_exec

Conversation

@vip-amzn
Copy link
Copy Markdown
Contributor

@vip-amzn vip-amzn commented Nov 7, 2025

Issue #, if available:

  • Fix is_complete() logic:

The Issue with current logic:
For 5 tasks,

  1. When tolerated_failure_count=2, but min_successful is NOT explicitly set, the code defaults min_successful to len(executables) (5 tasks)
  2. With 3 successes and 2 failures (expected) (all 5 tasks completed), the completion check fails:
    • tolerated_failure_count is None → False (we have tolerance set)
    • failure_count == 0 → False (we have 2 failures)
    • success_count >= min_successful3 >= 5 → False ❌
  3. Result: is_complete() returned False even though all tasks were done, causing an infinite wait

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vip-amzn vip-amzn closed this Nov 7, 2025
@wangyb-A wangyb-A deleted the fix_concurrent_exec branch December 9, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant