docs: fix duration format in examples#259
Merged
Conversation
Closes: aws#253 Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
yaythomas
approved these changes
Jan 16, 2026
Contributor
Python type checking is at design time, not run-time, so it won't fail at runtime. the reason mypy doesn't complain at design time, is because it's a Mock, not the actual object, and Mocks are very permissive with Any type. To test this, we'd have to add a concrete class that implements the DurableContext protocol rather than a mock. these tests focus on testing that the method exist on the protocol - i.e that the Protocol defines a wait method with the expected parameter names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #253
Issue #, if available:
Description of changes:
Update all examples and imports.
@yaythomas just not sure if we also need to fix
aws-durable-execution-sdk-python/tests/types_test.py
Lines 87 to 89 in f835016
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.