Skip to content

Use a blake2 to generate step_id#60

Merged
1 commit merged intomainfrom
32
Oct 17, 2025
Merged

Use a blake2 to generate step_id#60
1 commit merged intomainfrom
32

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 16, 2025

Signed-off-by: Astraea Sinclair quinsclr@amazon.com

Issue #, if available:
Fixes: #32

Description of changes:

  • Uses blade2 for hashing
  • Replaces explicit tests for step with sequence checks
  • Adds tests to verify the behaviour expected of the step id generation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ghost ghost marked this pull request as ready for review October 16, 2025 23:12
Copy link
Copy Markdown
Contributor

@yaythomas yaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@yaythomas yaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Feature:
- Replaces existing mechanism to produce durable operation ids with

Test Changes:
- Instead of testing manually the steps, we a/ produce a generator so
  that we can rely on next(_) to get the sequence
- We verify invariance over behaviour:
   - deterministic execution
   - identical generation for every new context
   - parent step id participates in the generation

Signed-off-by: Astraea Sinclair <quinsclr@amazon.com>
@ghost ghost merged commit 640d4e6 into main Oct 17, 2025
6 checks passed
@wangyb-A wangyb-A deleted the 32 branch December 9, 2025 22:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash Operation ID on DurableContext._create_step_id

3 participants