Merged
Conversation
- Adds completion reason inference based on the rules outlined in the typescript implementation / spec. fixes: #36
ghost
force-pushed
the
batch-completion-assumption
branch
2 times, most recently
from
ca2dbb7 to
fc0992a
Compare
rarepolz
approved these changes
Oct 22, 2025
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds completion reason inference based on the rules outlined in the typescript implementation / spec.
When all items are completed/failed, we assume ALL_COMPLETED
When we breach min successful, we assume MIN_SUCCESSFUL_REACHED
We assume we've failed completion due to errors
fixes: #36
closes: #71 as duplicate. Duplicating as #71 as source my fork, and CI breaks.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.