Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 95.80% 92.59% -3.21%
==========================================
Files 61 71 +10
Lines 8143 10177 +2034
Branches 0 10177 +10177
==========================================
+ Hits 7801 9423 +1622
- Misses 342 459 +117
- Partials 0 295 +295 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
prebuilt-libcrypto
branch
4 times, most recently
from
69bdbe6 to
ab65fbe
Compare
justsmth
force-pushed
the
prebuilt-libcrypto
branch
2 times, most recently
from
9971e59 to
89d3406
Compare
Allow aws-lc-sys to link against a pre-existing AWS-LC installation instead of building from source, controlled by the PREBUILT_INSTALL_DIR environment variable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…iggers - Filter empty PREBUILT_BINDINGS env var to avoid confusing warnings - Panic instead of silently falling back when bundled version can't be read - Add rerun-if-env-changed for STATIC and rerun-if-changed for library files - Extract BindingOptions::external_default() to reduce duplication - Replace #[allow(dead_code)] with #[cfg(test)] for test-only accessors - Remove verbose doc comment on handle_prebuilt_build Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
justsmth
force-pushed
the
prebuilt-libcrypto
branch
from
89d3406 to
c59aef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.