Update formal verification section in README.md#2301
Merged
darylmartin100 merged 3 commits intoaws:mainfrom Apr 3, 2025
Merged
Update formal verification section in README.md#2301darylmartin100 merged 3 commits intoaws:mainfrom
darylmartin100 merged 3 commits intoaws:mainfrom
Conversation
33bb213 to
0d5cd94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
- Coverage 78.74% 78.72% -0.02%
==========================================
Files 616 616
Lines 107588 107588
Branches 15286 15286
==========================================
- Hits 84715 84698 -17
- Misses 22218 22236 +18
+ Partials 655 654 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
darylmartin100
previously approved these changes
Apr 2, 2025
justsmth
previously approved these changes
Apr 2, 2025
justsmth
approved these changes
Apr 3, 2025
darylmartin100
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR updates the formal verification section in README with P-256 curve.
The update could be confirmed by checking:
The
third_party/s2n-bignumdirectory (https://github.com/aws/aws-lc/tree/main/third_party/s2n-bignum) against the places the functions are actually used (https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p384.c for P384, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p521.c for P512, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p256-nistz.c for P256, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/curve25519/curve25519_s2n_bignum_asm.c for X25519 and ED25519, and PR #1135 for RSA).Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.