Skip to content

Update formal verification section in README.md#2301

Merged
darylmartin100 merged 3 commits intoaws:mainfrom
pennyannn:yppe/update-fv
Apr 3, 2025
Merged

Update formal verification section in README.md#2301
darylmartin100 merged 3 commits intoaws:mainfrom
pennyannn:yppe/update-fv

Conversation

@pennyannn
Copy link
Copy Markdown
Contributor

@pennyannn pennyannn commented Mar 31, 2025

Description of changes:

This PR updates the formal verification section in README with P-256 curve.

The update could be confirmed by checking:
The third_party/s2n-bignum directory (https://github.com/aws/aws-lc/tree/main/third_party/s2n-bignum) against the places the functions are actually used (https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p384.c for P384, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p521.c for P512, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p256-nistz.c for P256, https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/curve25519/curve25519_s2n_bignum_asm.c for X25519 and ED25519, and PR #1135 for RSA).

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@pennyannn pennyannn requested a review from a team as a code owner March 31, 2025 17:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (93c213f) to head (8048a71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   78.74%   78.72%   -0.02%     
==========================================
  Files         616      616              
  Lines      107588   107588              
  Branches    15286    15286              
==========================================
- Hits        84715    84698      -17     
- Misses      22218    22236      +18     
+ Partials      655      654       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

darylmartin100
darylmartin100 previously approved these changes Apr 2, 2025
justsmth
justsmth previously approved these changes Apr 2, 2025
Comment thread README.md Outdated
@pennyannn pennyannn dismissed stale reviews from justsmth and darylmartin100 via e8d052d April 2, 2025 23:06
@darylmartin100 darylmartin100 enabled auto-merge (squash) April 3, 2025 01:57
@darylmartin100 darylmartin100 merged commit 3bbb078 into aws:main Apr 3, 2025
110 of 113 checks passed
@pennyannn pennyannn deleted the yppe/update-fv branch April 9, 2025 18:10
@justsmth justsmth mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants