-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase: 8.4.0 #184
Open
karenc-bq
wants to merge
26
commits into
main
Choose a base branch
from
rebase/8.4.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebase: 8.4.0 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es support Change-Id: I2ed95b4dfdb9fbd6bf17ae24dd2c6302b30f170a
… ODBC 8.1 connector Change-Id: Ibc6e32a9e5105d7cc721d1c36290f7cf53c88642
Change-Id: Idb19f0f4b9149c49f22bf20424000013ef6ca283
…when multiple rows are fetched Change-Id: I5468aaab3730dd6e558a60b13d0fb80388a6a177
Change-Id: If069541d26580a66193530e9c3953df23d3011b7
Change-Id: Iae85cca6881a021fa06c220a1e903a90f6fc8b6d
Change-Id: Iceb537c2305f32e76928add7436e926303500000
Change-Id: I6c5ea26bcc6dbed1443d059ad7d5021fc5b58aef
…ins in a new location on Win
…to 0 value Change-Id: I274a6d289faf53d5abbbfbf544efc1c59c6311ae
Change-Id: I165360a99091f144b8c51e2dd5c731d9783f9a00
Starting in GCC 14, it will begin enforcing C99 so errors regarding incompatible pointer types and so on will be more common. There are currently three C99 build errors that occur: 1: test/odbctap.h:107:18: error: implicit declaration of function `wcslen' [-Wimplicit-function-declaration] 107 | for (i= 0; i < wcslen(wstr); ++i) 2: test/odbctap.h:601:20: error: initialization of `SQLWCHAR *' {aka `short unsigned int *'} from incompatible pointer type `wchar_t *' {aka `int *'} [-Wincompatible-pointer-types] 601 | SQLWCHAR *val_a= (a), *val_b= (b); 3: error: passing argument 6 of `SQLGetData' from incompatible pointer type [-Wincompatible-pointer-types] 1172 | ok_stmt(hstmt, SQLGetData(hstmt, 0, SQL_C_BOOKMARK, abookmark, 255, &outlen)); The first is fixed by importing <wchar.h>, the second by changing SQLWCHAR to wchar_t, and the third by setting outlen's type to the SQLLEN type.
Change-Id: I8399fc712322c590f73f84a6901ac82069e42fe6
Change-Id: Ide9501d1f5312e3bb6e15399dde35a1e9985378c
Change-Id: I0573c06596818e00128a52076d3814e61056a6ba
karenc-bq
force-pushed
the
rebase/8.4.0
branch
2 times, most recently
from
June 18, 2024 19:57
aa9bb60
to
d85f211
Compare
ColinKYuen
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went thru the changes, but its out of date from our mainline now with conflicts 😔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rebase commits from 8.3.0 to 8.4.0: mysql/mysql-connector-odbc@8.3.0...8.4.0
Description
Review Status
Additional Reviewers