Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dockerized tests to run on Windows #207

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ColinKYuen
Copy link
Contributor

@ColinKYuen ColinKYuen commented Aug 29, 2024

Summary

Updates Dockerized Integration tests to be able to run on Windows Machines locally

Description

  • Pipes in n via yes to apt-get to auto decline configuration changes, e.g. when installing UnixOdbc so it won't update the odbc.ini file.
    • Unsure why UnixOdbc prompts this when done via test container executes on Windows but not on Linux or when starting a interactive bash session.
  • Runs the AWS SDK build script on the dockerized container to be able to create libraries needed when building the driver in Dockerized Container / Linux
    • Increases runtime as it will try to clone & do cmake, but won't do a full build if libraries already exist, e.g. if GH caches previous builds or if built locally
  • Made SESSION_TOKEN optional. Prior to change, will cause test setup failures as it will try to do String function isEmpty() on a null object.
  • Not part of this PR's scope, but some tests are still failing and causing segmentation faults and resulting in test container aborting with either 134 or 139. Issue exists when host system is Linux or Windows. These tests are flakey and have worked on occasion.

image

Review Status

  • This is ready for review
  • This is complete

Additional Reviewers

@ColinKYuen ColinKYuen changed the title chore: update dockerized tests to run on Windows [WIP] chore: update dockerized tests to run on Windows Aug 30, 2024
@ColinKYuen ColinKYuen force-pushed the win-docker-inte-tests branch from 06b3f7c to a4e5446 Compare August 30, 2024 06:08
@ColinKYuen ColinKYuen changed the title [WIP] chore: update dockerized tests to run on Windows chore: update dockerized tests to run on Windows Aug 30, 2024
@ColinKYuen ColinKYuen force-pushed the win-docker-inte-tests branch from a4e5446 to 17cde9b Compare August 30, 2024 09:13
@ColinKYuen ColinKYuen merged commit d2d88ba into main Sep 3, 2024
7 checks passed
@ColinKYuen ColinKYuen deleted the win-docker-inte-tests branch September 3, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants