Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom endpoint support #218

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: custom endpoint support #218

wants to merge 5 commits into from
+2,438 −645

Conversation

karenc-bq
Copy link
Contributor

@karenc-bq karenc-bq commented Jan 10, 2025 •
edited
Loading

Summary

Support for RDS custom endpoints.

GUI:
image

Description

Review Status

  • This is ready for review
  • This is complete

Additional Reviewers

@karenc-bq karenc-bq added the wip Pull requests that are a work in progress label Jan 10, 2025
@karenc-bq karenc-bq force-pushed the feat/custom-endpoints branch from a010f12 to 08bdec3 Compare January 10, 2025 02:16
@karenc-bq karenc-bq force-pushed the feat/custom-endpoints branch from 098d646 to 1dbd66a Compare January 10, 2025 19:00
karenc-bq
karenc-bq commented Jan 10, 2025
View reviewed changes
driver/rds_utils.cc Outdated Show resolved Hide resolved
ColinKYuen
ColinKYuen reviewed Jan 10, 2025
View reviewed changes
driver/cache_map.cc Outdated Show resolved Hide resolved
driver/custom_endpoint_monitor.cc Outdated Show resolved Hide resolved
driver/custom_endpoint_monitor.cc Outdated Show resolved Hide resolved
driver/rds_utils.cc Outdated Show resolved Hide resolved
setupgui/windows/resource.h Outdated Show resolved Hide resolved
util/installer.cc Outdated Show resolved Hide resolved
driver/custom_endpoint_proxy.h Outdated Show resolved Hide resolved
driver/custom_endpoint_proxy.h Outdated Show resolved Hide resolved
jkwuc89
jkwuc89 reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jkwuc89 jkwuc89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 And thanks for breaking up changes into multiple commits. Will tests for this be added in this PR or a separate PR?

@karenc-bq
Copy link
Contributor Author

Looks good! 👍 And thanks for breaking up changes into multiple commits. Will tests for this be added in this PR or a separate PR?

Will add the tests in this PR as well

@karenc-bq karenc-bq changed the title [WIP] feat: custom endpoint support feat: custom endpoint support Jan 17, 2025
@karenc-bq karenc-bq added ready for review Pull requests that are ready to be reviewed and removed wip Pull requests that are a work in progress labels Jan 17, 2025
@karenc-bq karenc-bq force-pushed the feat/custom-endpoints branch 11 times, most recently from 4bbc8c9 to cb99e7b Compare January 22, 2025 05:59
@karenc-bq karenc-bq force-pushed the feat/custom-endpoints branch from cb99e7b to 77c9341 Compare January 22, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinKYuen ColinKYuen ColinKYuen left review comments

@jkwuc89 jkwuc89 jkwuc89 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready for review Pull requests that are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karenc-bq @jkwuc89 @ColinKYuen