Allow opt out of json pretty print in enclave_process_handle_all_replies#544
Open
Allow opt out of json pretty print in enclave_process_handle_all_replies#544
enclave_process_handle_all_replies#544Conversation
emostov
changed the title
enclave_process_handle_all_replies
clupuishere
force-pushed
the
print-json-without-newline-chars
branch
from
44a07c0 to
64e9da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
I did not find an issue for this, but I can create one if necessary. The only marginally related issue I saw is #483.
Description of changes:
Currently, all json is pretty printed. For ease of log ingestion/monitoring, this should be a single (unprettified) json line; specifically there should be no new line characters or superfluous indentation.
The change introduced here should not change api of the CLI itself, but instead just introduce the optionality to do non-pretty print for crate users. This change is done by adding a fifth boolean argument to
enclave_process_handle_all_replies, which is used to indicate wether or not to pretty print the json. For crate users who want to maintain the status quo, they can simply set this argument totrue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.