Merged
Conversation
This commit updates MSRV to 1.71 and bumps dependencies in the lock file. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit bumps `idna` to 1.0.3 in order to mitigate https://rustsec.org/advisories/RUSTSEC-2024-0421 Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit replaces `yaml-rust` with `yaml-rust2` in order to mitigate https://rustsec.org/advisories/RUSTSEC-2024-0320 Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit replaces `serde_cbor` with `ciborium` because the original crate has been deprecated: https://rustsec.org/advisories/RUSTSEC-2021-0127 Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit updates Clap from 3.2 to 4.4. This change is needed because old Clap has a dependency on crate `atty` which is unmaintained: https://rustsec.org/advisories/RUSTSEC-2024-0375 This commit updates the dependency version and the code. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit updates Cargo.lock after applying previous commits which bump dependencies. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit bumps version for `cargo-about` tool from 0.5.0 to 0.6.6. This fixes the problem with parsing Unicode licenses. In order to maintain MSRV 1.71.1 this commit adds stable toolchain which is used to run up-to-date `cargo-about` tool. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
This commit adds Unicode-3.0 to the list of allowed licenses, and updates the license attribution document. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
atanzu
force-pushed
the
update-rust-version-and-deps
branch
from
f17e792 to
a5f7c4f
Compare
eugkoira
reviewed
Jan 15, 2025
eugkoira
reviewed
Jan 15, 2025
| args.get_many::<String>("cpu-ids") | ||
| .map(|values| { | ||
| values | ||
| .map(|id| { |
Contributor
There was a problem hiding this comment.
however, ideally that refactoring should be in a separate commit as it's not much related to Clap upgrade
eugkoira
reviewed
Jan 15, 2025
| rustup target add --toolchain ${RUST_VERSION} ${ARCH}-unknown-linux-musl && \ | ||
| # Install stable toolchain (needed to run fresh cargo-about) | ||
| rustup toolchain install stable-${ARCH}-unknown-linux-gnu && \ | ||
| cargo +stable install cargo-about --version 0.6.6 --locked && \ |
eugkoira
approved these changes
Jan 15, 2025
mariusknaust
approved these changes
Jan 20, 2025
| serde = { version = ">=1.0", features = ["derive"] } | ||
| chrono = "0.4" | ||
| clap = "3.2" | ||
| clap = "~4.4" |
Member
There was a problem hiding this comment.
We should consider to refactor this to use the clap derive feature in the future, might simplify the code a little.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The purpose of this PR is to unblock developers by satisfying the requirements coming from automated security and license checks. Without these changes, automated scanners will block new pull requests.
make update-third-party-licenses-rust-crates-htmlBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.