Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level in drain helper #1153

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

tiationg-kho
Copy link
Contributor

Issue #, if available:
#1148

Description of changes:

Fix log level in drain helper by passing custom loggers.

Ref:

How you tested your changes:
Environment (Linux / Windows): Linux
Kubernetes Version: 1.32

Test by:

  • e2e test
  • deploy NTH by private ECR image; trigger spot interruption; validate the log messages

Prev:

INF Draining the node
??? evicting pod kube-system/ebs-csi-controller-xxx
??? error when evicting pods/"ebs-csi-controller-xxx" -n "kube-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

Cur:

INF Draining the node
INF evicting pod kube-system/ebs-csi-controller-xxx
ERR error when evicting pods/"ebs-csi-controller-xxx" -n "kube-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tiationg-kho tiationg-kho requested a review from a team as a code owner April 3, 2025 02:04
@tiationg-kho tiationg-kho requested a review from Lu-David April 3, 2025 16:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some of our test files are using log.Logger instead of ZeroLog.Logger. Do they need to be updated as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking btw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have checked they are using same package. For the test cases, they do not validate base on log level. Might just keep them.

@tiationg-kho tiationg-kho merged commit 43be141 into aws:main Apr 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants