-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Explicitly exit when container is out-of-memory #6476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec451f2.
github-actions
bot
added
area/local/start-api
sam local start-api command
area/local/invoke
sam local invoke command
area/local/start-invoke
pr/internal
labels
Dec 20, 2023
mildaniel
commented
Dec 20, 2023
|
||
state = self.container_manager.inspect(self.container.id) | ||
|
||
if isinstance(state, bool): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is admittedly a little weird, but mypy won't like it if we don't do this, and the reason we return a bool here is to follow the legacy pattern in container_manager
.
mndeveci
reviewed
Dec 21, 2023
mildaniel
changed the title
Out of memory
fix: Explicitly exit when container is out-of-memory
Jan 2, 2024
jysheng123
approved these changes
Jan 3, 2024
mndeveci
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/local/invoke
sam local invoke command
area/local/start-api
sam local start-api command
area/local/start-invoke
pr/internal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6260
Why is this change necessary?
When an invoke container exits because it's out of memory, SAM CLI doesn't communicate this to customers and it's unclear why the invocation failed.
How does it address the issue?
Explicitly note the exit reason is out-of-memory and exit with return code 1 instead of 0.
What side effects does this change have?
Existing invocations that fail due to out-of-memory will return exit code 1.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.