Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update Python version to 3.11 for Terraform Build Docker Image #7870

Closed
wants to merge 1 commit into from

Conversation

vicheey
Copy link

@vicheey vicheey commented Feb 6, 2025

Which issue(s) does this change fix?

This would fix the AllTerraformBuildTesting integration test failure in the main canary.

Why is this change necessary?

This #7854 update AppVeyor to Python 11 and t #7862 only update to Python 3.9.

INFO     tests.integration.buildcmd.test_build_terraform_applications:test_build_terraform_applications.py:57 {'stream': '\x1b[91mTopic python3.9 is not found.\n\x1b[0m'}
INFO     tests.integration.buildcmd.test_build_terraform_applications:test_build_terraform_applications.py:57 {'errorDetail': {'code': 4, 'message': "The command '/bin/sh -c amazon-linux-extras enable python3.9' returned a non-zero code: 4"}, 'error': "The command '/bin/sh -c amazon-linux-extras enable python3.9' returned a non-zero code: 4"}
------------------------------ Captured log call ------------------------------
INFO     tests.testing_utils:testing_utils.py:68 Running command: samdev build function9 --use-container --build-image sam-terraform-python-build:v1 --hook-name terraform
INFO     tests.testing_utils:testing_utils.py:72 Stdout: 
Build Failed

....

Starting Build inside a container
Building layer 'module.layer9.aws_lambda_layer_version.this[0]'
For container layer build, first compatible runtime is chosen as build target for container.
Error: Could not find sam-terraform-python-build:v1 image locally and failed to pull it from docker.
------------------------------ Captured log call ------------------------------
INFO     tests.testing_utils:testing_utils.py:68 Running command: samdev build function9 --use-container --build-image sam-terraform-python-build:v1 --hook-name terraform
INFO     tests.testing_utils:testing_utils.py:72 Stdout: 
Build Failed

How does it address the issue?

This match the Python version needed by docker for Terraform test to use the Python 11 available on AppVeyor.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey requested a review from a team as a code owner February 6, 2025 07:12
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Feb 6, 2025
@vicheey vicheey removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Feb 6, 2025
@vicheey
Copy link
Author

vicheey commented Feb 6, 2025

Postpone merging this PR for now in favor of #7871

@roger-zhangg
Copy link
Member

Should close this one as We are reverting to 3.9

@vicheey
Copy link
Author

vicheey commented Feb 6, 2025

We can close this for now. Let's remember to update this later when we migrate to 3.11

@vicheey vicheey closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants