Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw converter not found instead of generic IndexOutOfBound exception #5538

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ar0d10n
Copy link

@ar0d10n ar0d10n commented Aug 27, 2024

Throw converter not found instead of generic IndexOutOfBound exception

Motivation and Context

#3845

Modifications

Added parameter validation and throwing appropriate exception instead of generic IndexOutOfBound for default attribute converter and enhanced document

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@ar0d10n ar0d10n requested a review from a team as a code owner August 27, 2024 14:44
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
62.9% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@debora-ito
Copy link
Member

@ar0d10n this seems a duplicate of #5329, should we close that one?

@ar0d10n
Copy link
Author

ar0d10n commented Sep 2, 2024

@debora-ito yes, we can close the #5329 in favor of this PR since current one has build results

@ar0d10n ar0d10n added this pull request to the merge queue Sep 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 16, 2024
#5538)

* Throw converter not found instead of generic IndexOutOfBound exception fixing #3845

* Amazon DynamoDB Update: added size check to param validation, style changes in unit tests
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@zoewangg zoewangg added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants