Improvements for NEGOTIATE usage - #7285
Merged
dagnir merged 2 commits intoAug 17, 2026
Merged
Conversation
NEGOTIATE depends on ambient, expiring, host-level state rather than on anything the customer passes to the builder, and none of that was documented. Spell out on the enum constant that credentials come from the ticket cache and never from a prompt or keytab, that a missing or expired ticket is not detected at build time and instead fails when a proxy connection is established, that the service principal is derived from the configured proxy host so an IP literal will not work, and that the JDK's GSS and JAAS modules must be present in the runtime image. Also note on the builder setter that username and password are ignored for NEGOTIATE, so credentials left in place while switching schemes are not silently assumed to be in use.
NEGOTIATE authenticates from the Kerberos ticket cache, so a username and password configured alongside it are dead configuration. Switching an existing Basic proxy configuration over to NEGOTIATE and leaving the credentials in place therefore looks like it still uses them, with no signal either way. Warn at build() rather than reject, and only when the credentials were set directly on the builder: values resolved from system properties or environment variables may not be under the caller's control, so warning about those would be noise they cannot act on.
Fred1155
approved these changes
Aug 17, 2026
dagnir
merged commit Aug 17, 2026
42be292
into
feature/master/netty-kerberos-proxy-auth
4 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License