Skip to content

Fix flaky test ResponsePublisherTimeoutIntegrationTest - #7342

Merged
S-Saranya1 merged 1 commit into
masterfrom
somepal/fix-flaky-response-publisher-timeout
Sep 4, 2026
Merged

Fix flaky test ResponsePublisherTimeoutIntegrationTest#7342
S-Saranya1 merged 1 commit into
masterfrom
somepal/fix-flaky-response-publisher-timeout

Conversation

@S-Saranya1

Copy link
Copy Markdown
Contributor

Motivation and Context

defaultTimeout_firstPublisherNotConsumed_secondRequestTimesOut flakes with Expecting code to raise a throwable because the 5-byte content ("Hello") is received as a FullHttpResponse by Netty. In ResponseHandler, the FullHttpResponse path calls finalizeResponse() which releases the connection back to the pool immediately, so the second request acquires it and succeeds instead of timing out.

Modifications

Increased content size to 2MB to force Netty to treat the response as a StreamedHttpResponse, which keeps the connection held until the publisher body is consumed or the timeout fires.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1
S-Saranya1 requested a review from a team as a code owner September 2, 2026 22:12
@S-Saranya1
S-Saranya1 requested a review from RanVaknin September 2, 2026 23:45
@S-Saranya1
S-Saranya1 enabled auto-merge September 4, 2026 18:15
@S-Saranya1
S-Saranya1 added this pull request to the merge queue Sep 4, 2026
Merged via the queue into master with commit 3ebe2bd Sep 4, 2026
13 of 14 checks passed
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 4, 2026
@S-Saranya1
S-Saranya1 deleted the somepal/fix-flaky-response-publisher-timeout branch September 9, 2026 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants