feat(codegen): add defaultEnableSocketTimeout2026 customization config field - #7348
Merged
Merged
Conversation
Add a no-op Boolean field to the codegen customization config model so customization.config files carrying this key parse without error. Nothing consumes it yet, so no generated code or behavior changes. Prepares for the upcoming default socket-timeout feature.
zoewangg
added
the
changelog-not-required
joviegas
approved these changes
Sep 3, 2026
zoewangg
enabled auto-merge
September 3, 2026 21:50
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 4, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds a new customization-config field,
defaultEnableSocketTimeout2026, to the codegen customization model. It is additive and inert: the field is recognized when a service'scustomization.configis parsed, but nothing in codegen consumes it, so no generated code or runtime behavior changes.Modifications
Boolean defaultEnableSocketTimeout2026field (with Javadoc) and its getter/setter toCustomizationConfig, mirroring the existingdefaultNewRetries2026field.null(off).Testing
mvn install -pl :codegen -P quick(compile) succeeds.defaultNewRetries2026precedent (no dedicated test for that field either).Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License