Fix flaky ParallelScanIntegrationTest by adding pagination to scan requests - #7363
Merged
Merged
Conversation
S-Saranya1
force-pushed
the
somepal/fix-flaky-parallel-scan-test
branch
from
September 9, 2026 17:29
57bea4c to
2683b4a
Compare
dagnir
approved these changes
Sep 9, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ParallelScanIntegrationTest.testParallelScan flakes in preview builds with small count mismatches (off by 1–5 items) at the assertion comparing single-segment scan results against 10-segment parallel scan results. 16 failures in the last 14 days. The root cause is that neither scan paginates - DynamoDB scan returns at most 1MB per call, and on the shared CI table with accumulated data, responses get truncated at different boundaries for the single-segment and multi-segment scans, producing different filtered counts.
Modifications
Replaced single-call dynamo.scan() with dynamo.scanPaginator() for both the single-segment scan and each of the 10 parallel segment scans, so all pages are read automatically before comparing counts. Also extracted the shared scan filter to reduce duplication.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License