Re: [aws/aws-sdk-net] Modify CloudSearch Search to use POST instead of GET (#900)

[joel-cass]

Description

Please see ticket #900

Changing GET to POST allows large requests to be processed. This has been addressed in java equivalent code according to comments on the ticket.

Motivation and Context

Its been 4 years and no useful response from AWS. I am hoping this PR expedites the process

Issue 900 #900

Testing

Testing method also in ticket

Refer to ticket 900

Screenshots (if appropriate)

Types of changes

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [ x] My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• [x ] I confirm that this pull request can be released under the Apache 2 license

[ashovlin]

Thanks for opening a PR.

As pointed out in the issue discussion, this file is generated from the service model, which specifies "GET" here. Unfortunately the current implementation of this change would get overwritten during the SDK release when we run the generator.

Let me:

1. Ask around internally with how other AWS SDKs are handling this.
   1. In addition to Java, it looks like Ruby has done some work here
   2. and PHP - Use POST instead of GET for CloudSearch Domain Search aws-sdk-php#1045
   3. and JS - Uses POST instead of GET for CloudSearch Domain search operation aws-sdk-js#976
2. Think about if and how we'd want to approach this to avoid clashing with the generated code. We do have customization hooks in the generator that let us plug in functions that can modify requests before or after the generated code.

[boblodgett]

I am closing this PR because the change will not stick. It would be overwritten by the generator in the next release. We will need to have the service team change the model or add a generator customization to fix this problem.

I have also requested ticket #900 in our backlog be priority re-evaluated by the team.