[V4] Updated support for bidi characters in resource paths. #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Jul 1, 2024
boblodgett
force-pushed
the
boblod-v4-bidi
branch
from
9769751
to
ea640be
Compare
|
Force push was a rebase on the latest v4-development to include a fix for an unrelated test from this PR: #3369 |
| var canonicalizedResourcePath = AWSSDKUtils.JoinResourcePathSegments(encodedSegments, false); | ||
| #pragma warning restore 0618 | ||
| // Get the logger each time (it's cached) because we shouldn't store it in a static variable. | ||
| Logger.GetLogger(typeof(AWSSDKUtils)).DebugFormat("{0} encoded {1}{2} for canonicalization: {3}", |
There was a problem hiding this comment.
FYI #3370 touches this path too and will require a rebase after this is merged (this is more a reminder for myself, feel free to ignore)
peterrsongg
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for bidi characters in request resource paths in more targets supported by the AWS SDK for .NET. This means applications that target .NET Framework 4.7.2+ and .NET Core 3.1+ will support bidi characters in requests. For the netstandard2.0 target bidi characters may be supported depending on your platform.
No longer will netstandard2.0 return the following error:
Instead if your platform using netstandard2.0 dlls doesn't correctly support bidi characters in the Uri class the following error will be returned:
Motivation and Context
Expands support for bidi characters opening up usage for more targets.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License