Feature/transfermanager #4193
Draft
Feature/transfermanager #4193
+30,674
−1,037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate docs and sync exception handling (#4187)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Transfer Manager feature for the AWS .NET SDK's S3 service, specifically adding enhanced download capabilities with response objects and lifecycle events. The changes include:
- New response-based methods for upload/download operations that return metadata
- Lifecycle events (initiated, completed, failed) for transfer operations
- Enhanced multipart download streaming with buffering support
- Atomic file operations for safer downloads
- Comprehensive test coverage for new functionality
Reviewed changes
Copilot reviewed 106 out of 127 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| BufferedMultipartStreamTests.cs | Unit tests for buffered multipart streaming functionality |
| BufferedDownloadConfigurationTests.cs | Unit tests for download configuration validation |
| BufferedDataSourceTests.cs | Unit tests for buffered data source reading |
| AtomicFileHandlerTests.cs | Unit tests for atomic file operations |
| TransferUtilityUploadDirectoryWithResponseTests.cs | Integration tests for directory upload with response |
| TransferUtilityUploadDirectoryLifecycleTests.cs | Integration tests for upload directory lifecycle events |
| TransferUtilityTests.cs | Enhanced integration tests with lifecycle events and response methods |
| TransferUtilityOpenStreamTests.cs | Integration tests for enhanced streaming downloads |
| TransferUtilityDownloadWithResponseTests.cs | Integration tests for file download with response |
| TransferUtilityDownloadDirectoryWithResponseTests.cs | Integration tests for directory download with response |
| TransferUtilityDownloadDirectoryLifecycleTests.cs | Integration tests for download directory lifecycle events |
| GetObjectTests.cs | Integration test for ContentLanguage header handling |
| AssemblyInfo.cs | Added InternalsVisibleTo for Moq dynamic proxy |
| ContentRangeParser.cs | New utility for parsing S3 ContentRange headers |
| TransferUtility.sync.cs | Synchronous wrapper methods for new response-based APIs |
| TransferUtility.async.cs | Async implementations for response-based directory operations |
| ITransferUtility.async.cs | Interface additions for response-based async methods |
| TransferUtilityUploadDirectoryResponse.cs | New response object for directory uploads |
| TransferUtilityOpenStreamResponse.cs | New response object for stream operations |
| TransferUtilityOpenStreamRequest.cs | Added MaxInMemoryParts property |
| TransferUtility.cs | Updated logger initialization and upload command return type |
sdk/src/Services/S3/Custom/Transfer/_bcl+netstandard/TransferUtility.sync.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License