Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through api options to item operations and support conditional w… #134

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

mullermp
Copy link
Contributor

Plumbs through put, update, and delete item options to underlying client calls. This is is necessary so that options like return_values and return_values_on_condition_check_failure can be configured. If return_values_on_condition_check_failure is used, the ConditionalWriteFailed error will have an original error instance of ConditionalCheckFailedException with item data that can be used.

spec/aws-record/record/item_operations_spec.rb Outdated Show resolved Hide resolved
lib/aws-record/record/item_operations.rb Outdated Show resolved Hide resolved
lib/aws-record/record/item_operations.rb Outdated Show resolved Hide resolved
lib/aws-record/record/item_operations.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

spec/aws-record/record/item_operations_spec.rb Outdated Show resolved Hide resolved
@mullermp mullermp merged commit 9e8fe6d into main Sep 28, 2023
25 checks passed
@mullermp mullermp deleted the conditional-check-error-plumbing branch September 28, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants