Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update net45 to net462 #233

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Update net45 to net462 #233

wants to merge 1 commit into from

Conversation

jon-armen
Copy link
Contributor

Description of changes:

  • Remove support for net45 (obsolete)
  • Add support for net462

Extracted work from #223 to reduce the amount of change in a single PR. Will update #223 for netcoreapp3.1 and net6.0 changes separately.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jon-armen jon-armen requested a review from a team as a code owner March 8, 2022 01:54
@jon-armen jon-armen changed the base branch from master to 3.x March 18, 2022 11:08
@jon-armen
Copy link
Contributor Author

@srprash , I've updated this pr to go into the 3.x line if we want to move this work to that branch.

@srprash
Copy link
Collaborator

srprash commented Mar 28, 2022

Hi @jon-armen
Yes, we would like to trace the breaking changes in the 3.x branch. Thanks for doing this. :)

@jon-armen
Copy link
Contributor Author

@srprash , handled the merge issues. Once we start moving these pr's thru, I'll work towards updating to support dotnet6.

@jon-armen jon-armen force-pushed the net462 branch 2 times, most recently from d124bfd to a29ffe7 Compare April 4, 2022 16:57
@jon-armen
Copy link
Contributor Author

@srprash - I've fixed the commits squashing this change to a single commit.

@jon-armen
Copy link
Contributor Author

This obsoletes #101

@jon-armen
Copy link
Contributor Author

@srprash - I've merged this down to a single commit. Are we in a position where we can merge into 3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants